known warning

From: Terry R. Friedrichsen (terry_at_uplift.sunquest.com)
Date: Thu Jan 04 2001 - 14:23:42 GMT


>From "Known bugs" on the ups web site:


> o  Compiler warning about ups/obj_misc.c is expected :
>
>      ./obj_misc.c: In function `do_srchead':
>      ./obj_misc.c:492: warning: passing arg 1 of `iterate_over_source_files'
>      from incompatible pointer type

The way to fix this is probably to create a new function for the call to
use.  The new function should take a fil_t argument and call the referenced
function with the same argument, casting it to objid_t.  Here's the way I
fixed it (I'm not saying it's *pretty* ...).

Terry R. Friedrichsen

terry_at_venus.sunquest.com


*** obj_misc.c.dist     Thu Sep  9 08:24:19 1999
--- obj_misc.c  Thu Jan  4 07:12:54 2001
***************
*** 59,64 ****
--- 59,65 ----
  static void add_module_object_if_necessary PROTO((Module *module));
  static int modfunc_cmp PROTO((objid_t obj1, objid_t obj2));
  static void set_max_module_width PROTO((Module *module));
+ static void fil_note_file_collapsed PROTO((fil_t *fil, bool flag));
  static void update_displayed_file_entries PROTO((objid_t par));
  static int src_cmp2 PROTO((objid_t obj1, objid_t obj2));
  
***************
*** 489,495 ****
                break;
        case MR_HIDE_SOURCE_FILES_COMPLETELY:
                update_displayed_file_entries(obj);
!               iterate_over_source_files(note_file_collapsed, FALSE);
                remove_object(obj, OBJ_DESCENDENTS);
                break;
        case MR_ADD_SOURCE_PATH:
--- 490,496 ----
                break;
        case MR_HIDE_SOURCE_FILES_COMPLETELY:
                update_displayed_file_entries(obj);
!               iterate_over_source_files(fil_note_file_collapsed, FALSE);
                remove_object(obj, OBJ_DESCENDENTS);
                break;
        case MR_ADD_SOURCE_PATH:
***************
*** 501,506 ****
--- 502,515 ----
                srcpath_check_and_add_path(path_str);
                break;
        }
+ }
+ 
+ static void
+ fil_note_file_collapsed(fil, flag)
+ fil_t *fil;
+ bool flag;
+ {
+   note_file_collapsed((objid_t)fil, flag);
  }
  
  static void


This archive was generated by hypermail 2.1.4 : Wed Feb 13 2002 - 21:51:33 GMT